Only write checksum if we have a valid file info #25776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Mar 1, 2021
PVince81
approved these changes
Mar 11, 2021
Because I'm not very confident in this area of our code and the |
rullzer
force-pushed
the
fix/sabre-file-checksum-no-file-info
branch
from
3032b62 to
8152189
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #16263 #10359
I don't yet know why this happens or if we also have to fix the missing file info. But this code is not checking for the possible
falsevalue of the file info after it had been "refreshed".