[stable20] Only clear share password model when actually saved #26059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
ChristophWurst,
danxuliu,
juliusknorr,
nickvergessen,
PVince81,
rullzer and
skjnldsv
|
/compile amend / |
rullzer
approved these changes
Mar 11, 2021
Instead of always clearing the password in the share model, now only do it when it was actually saved. Fixes an issue where saving another field would clear the password too early and prevent it to be saved when the dropdown closed. Signed-off-by: Vincent Petry <vincent@nextcloud.com> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
backport/25911/stable20
branch
from
90fa3bb to
51ba0fa
Compare
skjnldsv
approved these changes
Mar 11, 2021
|
need someone with permissions to force merge... |
|
rebuilding manually... |
|
alright, the build gives the same diff... I should have looked, it's an unrelated psalm issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #25911