Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk the array of phone numbers #26079

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Chunk the array of phone numbers #26079

merged 2 commits into from
Mar 12, 2021

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Chunk the array of phone numbers
2e08c8b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix Test class name
a609074 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 22 milestone Mar 12, 2021
@nickvergessen
Copy link
Member Author

/backport to stable21

PVince81
PVince81 approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense

ChristophWurst
ChristophWurst approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks best as https://github.com/nextcloud/server/pull/26079/files?w=1

rullzer
rullzer approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@rullzer rullzer merged commit 7ac6eee into master Mar 12, 2021
@rullzer rullzer deleted the bugfix/noid/chunk-phone-search branch March 12, 2021 10:20
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 PVince81 approved these changes

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @rullzer @PVince81 @ChristophWurst