Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] limit constructing of result objects in file search #26088

Merged
merged 2 commits into from
Mar 18, 2021
Merged

[stable20] limit constructing of result objects in file search #26088

merged 2 commits into from
Mar 18, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 12, 2021 •
edited by icewind1991
Loading

backport of #26049

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.10 milestone Mar 12, 2021
@icewind1991 icewind1991 force-pushed the backport/26049/stable20 branch from bc962cc to 23536a8 Compare March 12, 2021 13:09
MorrisJobke
MorrisJobke approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 17, 2021
PVince81
PVince81 approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@icewind1991 @PVince81
limit constructing of result objects in file search
57042ab 
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.

this saves about 40% of the time spend in the search request in my local testing

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @PVince81
implement PagedProvider for file search
e36e4a5 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@PVince81 PVince81 force-pushed the backport/26049/stable20 branch from 23536a8 to e36e4a5 Compare March 18, 2021 07:22
@PVince81
Copy link
Member

rebased and hoping for psalm stuff to pass

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 18, 2021
@PVince81 PVince81 merged commit 7dfb3af into stable20 Mar 18, 2021
@PVince81 PVince81 deleted the backport/26049/stable20 branch March 18, 2021 10:22
This was referenced Mar 26, 2021
Merged
Merged
@rullzer rullzer mentioned this pull request Apr 8, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@rullzer rullzer Awaiting requested review from rullzer

@kesselb kesselb Awaiting requested review from kesselb

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 20.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @MorrisJobke @icewind1991