[stable21] Fix non LGC glyphs in avatars and txt file previews #26249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Generated avatars as well as text file previews are rendered using the "core/fonts/NotoSans-Regular.ttf" font. The file was the standard hinted "NotoSans-Regular.ttf" file from https://www.google.com/get/noto/. However that file does not cover some non LGC (Latin, Greek, Cyrillic) scripts, like Arabic, Devanagari or Hebrew, to name a few. Markdown file previews also use "core/fonts/NotoSans-Bold.ttf", which is in the same situation as the regular one. Due to limitations in the TTF format it is not possible to provide a single file for each style that includes all Noto fonts. However, it is possible to add more scripts to the standard "NotoSans-Regular.ttf" and "NotoSans-Bold.ttf" files (although no CJK (Chinese, Japanese, Korean) glyph can be included due to the aforementioned limitations). This commit replaces the standard files with an extended version created using the Noto Tools. The build script (as well as a patch for the Noto Tools) is also included for reference and to be able to update the font files in the future if needed. Due to the additional scripts added the font files are now much larger, although this does not seem to increase the time spent rendering LGC scripts. Note that the file for the bold style still contains less scripts than the regular one, as not all scripts supported by Noto have a bold weight. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The command is meant to be used when the fonts used to render texts
("core/fonts/NotoSans-Regular.ttf" and "core/fonts/NotoSans-Bold.ttf")
are changed (for example, to add support for other scripts). The avatar
and text file previews will be removed, so they will be generated again
with the updated font when needed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
backportbot-nextcloud
bot
requested review from
ChristophWurst,
danxuliu,
juliusknorr and
rullzer
MorrisJobke
approved these changes
Mar 22, 2021
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #25529