Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve type handling of Avatar::generateAvatarFromSvg #26282

Merged
merged 1 commit into from
Mar 24, 2021
Merged

improve type handling of Avatar::generateAvatarFromSvg #26282

merged 1 commit into from
Mar 24, 2021

Conversation

icewind1991
Copy link
Member

Noticed plsam complaining

@icewind1991
improve type handling of Avatar::generateAvatarFromSv
db0e198 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 24, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Mar 24, 2021
MorrisJobke
MorrisJobke approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍

PVince81
PVince81 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2021
@MorrisJobke MorrisJobke merged commit 2a74988 into master Mar 24, 2021
@MorrisJobke MorrisJobke deleted the psalm/avatar/data branch March 24, 2021 20:46
@kesselb
Copy link
Contributor

kesselb commented May 26, 2021

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@kesselb kesselb Awaiting requested review from kesselb

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
4 participants
@icewind1991 @kesselb @MorrisJobke @PVince81