-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow using any ldap property as login name when using external storage login credentials #26397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside my nitpick it looks good and once #25326 is in then I'm fine with the merge 👍
0ca0287
to
785a158
Compare
Please rebase :) |
785a158
to
53640ab
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one hint to decouple from user_ldap internals, otherwise looking good.
53640ab
to
0c5fcee
Compare
0c5fcee
to
0bf3536
Compare
I just fixed the code style complaint. |
$loginKey = $storage->getBackendOption("login_ldap_attr"); | ||
if ($loginKey) { | ||
$backend = $user->getBackend(); | ||
if ($backend instanceof IUserBackend && $backend->getBackendName() === 'LDAP') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense 👍
CI is unhappy |
0bf3536
to
28c0417
Compare
…ge login credentials Signed-off-by: Robin Appelman <robin@icewind.nl>
28c0417
to
592d6d5
Compare
ci happy |
New try for #24955