Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lookup search explicit #26633

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Make lookup search explicit #26633

merged 1 commit into from
Apr 20, 2021

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 19, 2021

Speedsup sharee lookup quite a bit.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Make lookup search explicit
dcd4542 
Speedsup sharee lookup quite a bit.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added enhancement 3. to review Waiting for reviews labels Apr 19, 2021
@rullzer rullzer added this to the Nextcloud 22 milestone Apr 19, 2021
MorrisJobke
MorrisJobke approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice performance improvement 🚀

@MorrisJobke
Copy link
Member

Bildschirmfoto 2021-04-19 um 21 46 53

@MorrisJobke
Copy link
Member

Retriggered CI to check if this is related.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2021
@rullzer
Copy link
Member Author

rullzer commented Apr 19, 2021

I thinkthis one is failing since some time now?

@nickvergessen
Copy link
Member

Yes there is an issue by vincent about it

@juliusknorr
Copy link
Member

#26314 for reference

@juliusknorr juliusknorr merged commit 59f8685 into master Apr 20, 2021
@juliusknorr juliusknorr deleted the enh/sharee/lookup_later branch April 20, 2021 06:38
@rullzer
Copy link
Member Author

rullzer commented Apr 20, 2021

/backport to stable21

@rullzer
Copy link
Member Author

rullzer commented Apr 20, 2021

/backport to stable20

@rullzer
Copy link
Member Author

rullzer commented Apr 20, 2021

/backport to stable19

@MorrisJobke
Copy link
Member

/backport to stable21

@MorrisJobke
Copy link
Member

/backport to stable20

@MorrisJobke
Copy link
Member

/backport to stable19

@backportbot-nextcloud
Copy link

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@MorrisJobke
Copy link
Member

@rullzer MInd to do the backports?

@rullzer
Copy link
Member Author

rullzer commented Apr 20, 2021

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 20, 2021
Merged
@rullzer
Copy link
Member Author

rullzer commented Apr 20, 2021

/backport to stable20

@rullzer
Copy link
Member Author

rullzer commented Apr 20, 2021

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 20, 2021
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
5 participants
@rullzer @MorrisJobke @nickvergessen @juliusknorr @LukasReschke