Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security credentials manager test #26654

Merged

Conversation

nickvergessen
Copy link
Member

.W.. 4 / 4 (100%)

Time: 118 ms, Memory: 30.50 MB

There was 1 warning:

  1. Test\Security\CredentialsManagerTest::testRetrieve
    Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

WARNINGS!
Tests: 4, Assertions: 6, Warnings: 1.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MorrisJobke MorrisJobke merged commit 9e8690d into master Apr 20, 2021
@MorrisJobke MorrisJobke deleted the bugfix/noid/fix-security-credentials-manager-test branch April 20, 2021 20:03
@@ -24,6 +24,9 @@
use OC\DB\ConnectionAdapter;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah dang it forgot to remove this one

@nickvergessen nickvergessen mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants