Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLD Fix LDAP Dark Theme Issue #26666

Closed
wants to merge 3 commits into from
Closed

OLD Fix LDAP Dark Theme Issue #26666

wants to merge 3 commits into from

Conversation

AndyXheli
Copy link

@AndyXheli AndyXheli commented Apr 20, 2021 •
edited
Loading

Should fix LDAP AD Integration Dark Theme issue #25809

How it looks with the code change
image

AndyXheli and others added 3 commits April 20, 2021 13:59
@AndyXheli
Fix LDAP Dark Theme Issue
372b538 
Signed-off-by: Andy Xheli <andyxheli@gmail.com>
@AndyXheli
Revert "Fix LDAP Dark Theme Issue"
971217b 
This reverts commit 7d96b34.

Signed-off-by: Andy Xheli <andyxheli@gmail.com>
@AndyXheli
Revert "Revert "Fix LDAP Dark Theme Issue""
f73d585 
This reverts commit 5b9804e.

Signed-off-by: Andy Xheli <andyxheli@gmail.com>
@kesselb
Copy link
Contributor

kesselb commented Apr 20, 2021

Hi, how does it look without dark mode? 🤔

@AndyXheli
Copy link
Author

AndyXheli commented Apr 20, 2021 •
edited
Loading

Looks good to me what you think ?
image

@szaimen szaimen added the 3. to review Waiting for reviews label Jun 18, 2021
@szaimen szaimen added this to the Nextcloud 22 milestone Jun 18, 2021
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021
@AndyXheli AndyXheli mentioned this pull request Jul 6, 2021
Closed
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 22, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
@AndyXheli AndyXheli mentioned this pull request Apr 8, 2022
Closed
@AndyXheli
Copy link
Author

Please ref Fix LDAP Dark Theme Issue #31904 updated the file. I wasn't able to update the file here so I created new pull request.

@szaimen Can we please get Fix LDAP Dark Theme Issue #31904 to be part of Nextcloud 24 as this this ? I'll close this so no confusion.

@AndyXheli AndyXheli closed this Apr 8, 2022
@AndyXheli AndyXheli changed the title Fix LDAP Dark Theme Issue OLD Fix LDAP Dark Theme Issue Apr 8, 2022
@szaimen szaimen removed this from the Nextcloud 24 milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb Awaiting requested review from kesselb

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: ldap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndyXheli @kesselb @jancborchardt @blizzz @skjnldsv @szaimen