Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamp tooltip #27051

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Add timestamp tooltip #27051

merged 1 commit into from
Jun 14, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented May 21, 2021 •
edited
Loading

@Pytal Pytal mentioned this pull request May 21, 2021
Merged
@Pytal Pytal self-assigned this May 21, 2021
@Pytal Pytal added the 3. to review Waiting for reviews label May 21, 2021
@skjnldsv skjnldsv added this to the Nextcloud 22 milestone May 21, 2021
@skjnldsv skjnldsv requested a review from enochterrymize May 21, 2021 05:22
juliusknorr
juliusknorr reviewed May 21, 2021
View reviewed changes
apps/files/src/views/Sidebar.vue Outdated
* @returns {string}
*/
fullTime() {
return OC.Util.formatDate(this.fileInfo.mtime)
Copy link
Member

@juliusknorr juliusknorr May 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should switch to use the @nextcloud/moment package here as the formatDate global has beed deprecated:

OC.Util.formatDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment

server/core/src/OC/util.js

Line 123 in 3e624dc

console.warn('OC.Util.formatDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes with @nextcloud/moment, what do you think?

@Pytal Pytal force-pushed the feat/timestamp-tooltip branch 12 times, most recently from 031e7b4 to 502a350 Compare May 25, 2021 23:58
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
Merged
98 tasks
@Pytal Pytal force-pushed the feat/timestamp-tooltip branch 2 times, most recently from 25e0919 to c09e3fb Compare May 26, 2021 15:58
skjnldsv
skjnldsv approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me :)
Needs an update of the vue components though

@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@Pytal Pytal force-pushed the feat/timestamp-tooltip branch from c09e3fb to f2a61d8 Compare June 2, 2021 17:03
@Pytal
Copy link
Member Author

Pytal commented Jun 2, 2021

bump :) just waiting on checks

@Pytal Pytal force-pushed the feat/timestamp-tooltip branch from f2a61d8 to b135938 Compare June 2, 2021 19:52
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
@juliusknorr
Copy link
Member

@Pytal Needs another rebase and update of the bundles

@Pytal
Add timestamp tooltip
c2e4c2a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/timestamp-tooltip branch from b135938 to c2e4c2a Compare June 14, 2021 17:07
@Pytal
Copy link
Member Author

Pytal commented Jun 14, 2021

@Pytal Needs another rebase and update of the bundles

Done and ready for launch 🚀

@Pytal Pytal merged commit 41b778d into master Jun 14, 2021
@Pytal Pytal deleted the feat/timestamp-tooltip branch June 14, 2021 19:51
@welcome
Copy link

welcome bot commented Jun 14, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 14, 2021
@Pytal Pytal mentioned this pull request Jun 14, 2021
Closed
@blizzz blizzz mentioned this pull request Jun 16, 2021
Merged
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge Awaiting requested review from artonge

@enochterrymize enochterrymize Awaiting requested review from enochterrymize

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

Show exact date and time of a photo in sidebar
3 participants
@Pytal @juliusknorr @skjnldsv