Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump marked from 1.2.8 to 1.2.9 #27228

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 28, 2021

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps marked from 1.2.8 to 1.2.9.

Release notes

Sourced from marked's releases.

v1.2.9

1.2.9 (2021-02-03)

Bug Fixes

  • allow sublist to be single space in pedantic (#1924) (1e36afd)
Commits
  • f2535f1 chore(release): 1.2.9 [skip ci]
  • f0dc8a2 🗜️ build [skip ci]
  • 1e36afd fix: allow sublist to be single space in pedantic (#1924)
  • b97b802 chore(deps-dev): Bump rollup from 2.38.0 to 2.38.3 (#1922)
  • 409ef11 chore(deps-dev): Bump @​rollup/plugin-babel from 5.2.2 to 5.2.3 (#1917)
  • f86549d chore(deps-dev): Bump rollup from 2.38.0 to 2.38.2 (#1916)
  • b2fe7c1 chore(deps-dev): Bump uglify-js from 3.12.5 to 3.12.6 (#1919)
  • aec6b9d chore(deps-dev): Bump @​rollup/plugin-commonjs from 17.0.0 to 17.1.0 (#1918)
  • afb285d chore(deps-dev): Bump eslint from 7.18.0 to 7.19.0 (#1920)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@MichaIng MichaIng added this to the Nextcloud 21.0.4 milestone Jul 10, 2021
@MichaIng
Copy link
Member

@dependabot rebase

@skjnldsv
Copy link
Member

@dependabot recreate

@MichaIng
Copy link
Member

The bot is somehow stuck on this one. I'll rebase manually.

@MichaIng MichaIng force-pushed the dependabot/npm_and_yarn/stable21/marked-1.2.9 branch from 9e9dedc to b3ad424 Compare July 15, 2021 09:32
@MichaIng
Copy link
Member

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the dependabot/npm_and_yarn/stable21/marked-1.2.9 branch from b3ad424 to 5b06ae1 Compare July 15, 2021 10:33
@MichaIng MichaIng force-pushed the dependabot/npm_and_yarn/stable21/marked-1.2.9 branch from 5b06ae1 to 18d001e Compare July 15, 2021 11:32
@github-actions github-actions bot force-pushed the dependabot/npm_and_yarn/stable21/marked-1.2.9 branch from 18d001e to dbc195b Compare July 15, 2021 19:17
@MichaIng
Copy link
Member

MichaIng commented Jul 16, 2021

/rebase

EDIT: Okay this github-actions bot rebase doesn't seem to trigger the tests 🤔.

@github-actions github-actions bot force-pushed the dependabot/npm_and_yarn/stable21/marked-1.2.9 branch from dbc195b to a77e4e7 Compare July 16, 2021 09:34
@MichaIng MichaIng force-pushed the dependabot/npm_and_yarn/stable21/marked-1.2.9 branch from a77e4e7 to c43ab5d Compare July 16, 2021 09:37
@skjnldsv
Copy link
Member

doesn't seem to trigger the tests

Yes, that's a github limitation :)

@MichaIng
Copy link
Member

Good to know. And my manual rebase triggers everything, but not the drone. Can it be triggered manually for this branch? The compile bot is down, so that one cannot be used.

Probably it's okay to merge as is, but at least I'm not brave enough to approve as long as not all check have passed 🙂.

@skjnldsv
Copy link
Member

The compile bot is down, so that one cannot be used

back up

@MichaIng
Copy link
Member

/compile amend /

@skjnldsv
Copy link
Member

Drone is having issues accepting those old dependabot PRs

@MichaIng
Copy link
Member

MichaIng commented Jul 16, 2021

Hmm, and dependabot does not react to @dependabot recreate for some reason. Not sure how to proceed 🤔. The drone would check the branch on merge, so we could see possible errors afterwards.

Wait, I think I know now why the bot has issues here: https://github.com/nextcloud/server/pulls?q=Bump+marked+from+1.2.8

The previews dependabot PRs were closed (aside of the one against master), which actually bumped marked to 2.0.0 already: https://github.com/nextcloud/server/pulls?q=Bump+marked+from+1.2.8

A little prove on my guess at the vue bump PR, that (non-preview) dependabot does not reopen or handle dependencies further when preview dependabot PRs were closed (contradicting the info it edited into the PRs OP). See #26414 which was closed in April already, so it's definitely not that we only need to wait for another workflow run.

So I suggest to reopen #26414, rebase it manually and compile + amend scripts. There are already newer versions in the meantime, but after merging that PR, I guess non-preview dependabot will again track new releases.


Or probably it's easier, when possible, to reset the dependabot's memory?

@skjnldsv
Copy link
Member

I think it would be best to have this in before
#27843

Bumps [marked](https://github.com/markedjs/marked) from 1.2.8 to 1.2.9.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js)
- [Commits](markedjs/marked@v1.2.8...v1.2.9)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@MichaIng MichaIng force-pushed the dependabot/npm_and_yarn/stable21/marked-1.2.9 branch from c43ab5d to b8be9c6 Compare July 17, 2021 14:02
@skjnldsv skjnldsv merged commit fcf82d5 into stable21 Jul 23, 2021
@skjnldsv skjnldsv deleted the dependabot/npm_and_yarn/stable21/marked-1.2.9 branch July 23, 2021 06:56
@skjnldsv
Copy link
Member

I think it would be best to have this in before
#27843

I didn't realized this was stable21

@skjnldsv skjnldsv mentioned this pull request Jul 26, 2021
14 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 3, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants