Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dav plugin to trigger recalculating of checksums #27378

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

icewind1991
Copy link
Member

Allows clients to ask the server to recalculate the stored checksums by sending a PATCH request with the X-Recalculate-Hash hash set.

For example

curl -X PATCH -u admin:admin -H 'X-Recalculate-Hash: sha1' https://cloud.example.com/remote.php/dav/files/admin/test.md

This will both update the stored checksum using the provided algorithm and return the new checksum in the OC-Checksum header

cc @allexzander

@nickvergessen
Copy link
Member

Code scanner is very unpleased 🙈 Not sure how much of that is valid, but maybe you can have a look

@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
@icewind1991 icewind1991 force-pushed the dav-recalc-checksum branch 2 times, most recently from 4113f0b to e822be6 Compare June 14, 2021 14:07
This was referenced Jun 16, 2021
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@nickvergessen
Copy link
Member

@icewind1991 mind to have a look at the code scanner warnings?

@icewind1991 icewind1991 force-pushed the dav-recalc-checksum branch 2 times, most recently from 7a10996 to 7882462 Compare August 23, 2021 13:23
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

icewind1991 commented Aug 23, 2021

ci happy

@PVince81
Copy link
Member

ci happy

the code scanner issues are still there like missing return types

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 31, 2021
@allexzander
Copy link

@icewind1991 I wonder if this needs to be followed up?

@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv
Copy link
Member

All green, merging @icewind1991 ?

This was referenced Oct 25, 2021
@skjnldsv skjnldsv merged commit e1bf5c1 into master Nov 1, 2021
@skjnldsv skjnldsv deleted the dav-recalc-checksum branch November 1, 2021 10:25
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish bug and removed 2. developing Work in progress labels Nov 1, 2021
@skjnldsv
Copy link
Member

skjnldsv commented Nov 1, 2021

Damn, that was a feature, not a bugfix, should not have merged, reverting and postponing for 24

EDIT: #29510

@skjnldsv
Copy link
Member

skjnldsv commented Nov 1, 2021

/backport to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants