Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some multiselect design fixes #27995

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 15, 2021

Multiselect view

Before After
image image
Other screenshots

Normal list view

Before After
image image

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added the 2. developing Work in progress label Jul 15, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Jul 15, 2021
@szaimen szaimen force-pushed the enh/noid/multiselect-design-fixes branch 2 times, most recently from 2bdaecf to 67fe287 Compare July 15, 2021 15:07
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/multiselect-design-fixes branch from 67fe287 to f4db7cb Compare July 15, 2021 15:09
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 15, 2021
@szaimen szaimen marked this pull request as ready for review July 15, 2021 15:45
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it look good on mobile too ?

@szaimen
Copy link
Contributor Author

szaimen commented Jul 15, 2021

On mobile nothing has changed:

Before After
image image

@szaimen szaimen requested review from skjnldsv and juliusknorr July 16, 2021 08:36
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 16, 2021
@juliusknorr juliusknorr merged commit 2766df9 into master Jul 16, 2021
@juliusknorr juliusknorr deleted the enh/noid/multiselect-design-fixes branch July 16, 2021 12:28
@szaimen
Copy link
Contributor Author

szaimen commented Jul 16, 2021

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Jul 16, 2021

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Jul 16, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 16, 2021

backport to stable22 in #28011
I am not bothering to backport to stable21 and stable20 since the backport bot has failed...

@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2021

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2021

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Jul 20, 2021

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants