Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an option to the multiple files selected actions to add and remov… #28133

Merged
merged 1 commit into from
Jul 23, 2021
Merged

add an option to the multiple files selected actions to add and remov… #28133

merged 1 commit into from
Jul 23, 2021

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 23, 2021 •
edited
Loading

image

@skjnldsv skjnldsv force-pushed the feat/tag_multiple_files_at_once branch 2 times, most recently from 8f8a0d0 to e0573ec Compare July 23, 2021 13:12
@skjnldsv
Copy link
Member Author

/backport to stable22

@skjnldsv skjnldsv marked this pull request as ready for review July 23, 2021 13:27
@skjnldsv skjnldsv added this to the Nextcloud 23 milestone Jul 23, 2021
@skjnldsv skjnldsv force-pushed the feat/tag_multiple_files_at_once branch from e0573ec to b830487 Compare July 23, 2021 13:29
PVince81
PVince81 reviewed Jul 23, 2021
View reviewed changes
apps/files/js/filelist.js Outdated Show resolved Hide resolved
apps/files/js/filelist.js Outdated Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/tag_multiple_files_at_once branch from b830487 to 8f9588f Compare July 23, 2021 13:33
julien-nc
julien-nc approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

Not a big deal but the tag_multiple_files_container disappears when clicking on Please select tag(s) to add to the selection.

PVince81
PVince81 reviewed Jul 23, 2021
View reviewed changes
apps/files/js/filelist.js Outdated Show resolved Hide resolved
apps/files/js/filelist.js Outdated Show resolved Hide resolved
apps/files/js/filelist.js Outdated Show resolved Hide resolved
apps/files/js/filelist.js Outdated Show resolved Hide resolved
apps/files/js/filelist.js Show resolved Hide resolved
PVince81
PVince81 approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the job 👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 23, 2021
@skjnldsv
Copy link
Member Author

Not a big deal but the tag_multiple_files_container disappears when clicking on Please select tag(s) to add to the selection.

Yes, it hides while adding in the background. I think we can do better, but I would do it when properly rewriting this feature to vue?

@skjnldsv skjnldsv force-pushed the feat/tag_multiple_files_at_once branch from dcc0786 to edc77b7 Compare July 23, 2021 15:42
@skjnldsv
add an option to the multiple files selected actions to add and remov…
c5af910 
…e tags from multiple files at once

Signed-off-by: Roland Scheidel <kontakt@scheidel.at>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/tag_multiple_files_at_once branch from edc77b7 to c5af910 Compare July 23, 2021 15:47
@julien-nc
Copy link
Member

Not a big deal but the tag_multiple_files_container disappears when clicking on Please select tag(s) to add to the selection.

Yes, it hides while adding in the background. I think we can do better, but I would do it when properly rewriting this feature to vue?

Yeah sure.
Just to be clear thoug: The selector disappears even if no tag was added/removed, just when one click on the label.

@skjnldsv skjnldsv merged commit 6817ba1 into master Jul 23, 2021
@skjnldsv skjnldsv deleted the feat/tag_multiple_files_at_once branch July 23, 2021 16:25
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 23, 2021
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 23, 2021
Closed
@siccovansas siccovansas mentioned this pull request Jul 23, 2021
Closed
17 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2021
Closed
@jancborchardt jancborchardt mentioned this pull request Aug 16, 2021
Closed
2 tasks
@jancborchardt
Copy link
Member

Two follow-up problems with this feature, opened a new issue: #28456

@duckdiver
Copy link

nice feature to tag multiple files.
Now it would also be nice to share files by tags or mutliple files at once from a folder, which is nowadays not possible.
does that make sence?
do you also recognize tags from external programs eg. qnap photostation?

@Spartachetto
Copy link

Spartachetto commented Oct 6, 2021 •
edited
Loading

@duckdiver first of all it is not advised to ask for different features in one issue dealing with a specific feature.

Second, I remember a really old feature request about sharing multiple files. It is #1291

@artonge artonge mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@PVince81 PVince81 PVince81 approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@artonge artonge Awaiting requested review from artonge

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@szaimen szaimen Awaiting requested review from szaimen

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files feature: tags
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
6 participants
@skjnldsv @julien-nc @jancborchardt @duckdiver @Spartachetto @PVince81