Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use case insensitive like when limiting search to jail #28476

Merged
merged 1 commit into from
Aug 24, 2021
Merged

use case insensitive like when limiting search to jail #28476

merged 1 commit into from
Aug 24, 2021

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Aug 17, 2021 •
edited
Loading

The case insensitivity isn't required and making the comparison case sensitive makes things easier for the database especially if we ever get a (partial) index on path

@icewind1991
use case insensitive like when limiting search to jail
c48f9ff 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 17, 2021
@icewind1991 icewind1991 requested review from PVince81 and ChristophWurst and removed request for PVince81 August 20, 2021 14:32
@icewind1991 icewind1991 added this to the Nextcloud 23 milestone Aug 20, 2021
@icewind1991 icewind1991 mentioned this pull request Aug 23, 2021
Closed
@icewind1991
Copy link
Member Author

/backport to stable22

PVince81
PVince81 approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense

the case insensitivity is only required for the original search string, not the post-filtering

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish feature: search and removed 3. to review Waiting for reviews labels Aug 24, 2021
@PVince81
Copy link
Member

failing test unrelated, merging

@PVince81 PVince81 merged commit e32d293 into master Aug 24, 2021
@PVince81 PVince81 deleted the search-jail-insensitive branch August 24, 2021 06:59
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 24, 2021
Merged
@icewind1991 icewind1991 mentioned this pull request Aug 26, 2021
Closed
This was referenced Oct 5, 2021
Merged
Merged
@skjnldsv
Copy link
Member

/backport to stable21

@skjnldsv
Copy link
Member

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@icewind1991
Copy link
Member Author

21 and 20 are done with #29080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: search
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
4 participants
@icewind1991 @PVince81 @skjnldsv @ChristophWurst