Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not load versions tab view if the files app is not available #28532

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Do not load versions tab view if the files app is not available #28532

merged 1 commit into from
Aug 20, 2021

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 20, 2021 •
edited
Loading

Fixes #27762

This avoids an error logged on any page that loads the files sidebar without the files app itself being in place (e.g. dashboard where the viewer pulls in the sidebar).

TypeError: undefined is not an object (evaluating 'OCA.Files.DetailTabView.extend')
  at call(./apps/files_versions/src/versionstabview.js:36:36)
  at __webpack_require__(webpack/bootstrap:19:22)
  at ? (webpack/bootstrap:83:10)
  at global code(apps/files_versions/js/files_versions.js:83:54)

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Aug 20, 2021
@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Aug 20, 2021
@juliusknorr juliusknorr requested a review from a team August 20, 2021 12:49
@juliusknorr
Do not load versions tab view if the files app is not available
def287c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/versions-tabview branch from f71567c to def287c Compare August 20, 2021 12:53
PVince81
PVince81 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉 🎉 🎉 🎉

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 20, 2021
@szaimen
Copy link
Contributor

szaimen commented Aug 20, 2021

/backport to stable22

@szaimen
Copy link
Contributor

szaimen commented Aug 20, 2021

/backport to stable21

@szaimen
Copy link
Contributor

szaimen commented Aug 20, 2021

/backport to stable20

@Pytal
Copy link
Member

Pytal commented Aug 20, 2021

⚙⚙⚙

@juliusknorr juliusknorr merged commit 23353ab into master Aug 20, 2021
@juliusknorr juliusknorr deleted the bugfix/noid/versions-tabview branch August 20, 2021 17:07
This was referenced Aug 20, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 PVince81 approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

OCA.Files.DetailTabView is undefined on dashboard page
5 participants
@juliusknorr @szaimen @Pytal @PVince81 @ChristophWurst