Add S3 SSE KMS key and bucket key encryption #28601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
juliusknorr
force-pushed
the
enh/s3-sse-kms
branch
from
7fa38f7 to
240d937
Compare
juliusknorr
added
3. to review
juliusknorr
changed the title
Merged
|
🏓 for review |
artonge
requested changes
Nov 2, 2021
| @@ -55,7 +60,7 @@ public function readObject($urn) { | |||
| 'Bucket' => $this->bucket, | |||
| 'Key' => $urn, | |||
| 'Range' => 'bytes=' . $range, | |||
| ]); | |||
| ] + $this->getSseKmsGetParameters()); | |||
There was a problem hiding this comment.
SseKmsPutParameters is placed under a config property, SseKmsGetParameters is not, is this right?
Merged
Merged
Merged
Merged
Merged
Merged
|
Closing this for now as there is no current demand. This can be picked up to finish anytime of course. |
juliusknorr
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally proposed by @tsdicloud this is the rebased version of #26899 with pulling the changes from https://github.com/nextmcloud/server/compare/master..s3fragment without the already merged parts from #27877