let user choose notification email in user settings #28840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
a team,
PVince81,
julien-nc and
skjnldsv
and removed request for
a team
blizzz
added
2. developing
Base automatically changed from
fix/noid/additional-mails-editable
to
master
September 15, 2021 01:22
blizzz
commented
Sep 15, 2021
blizzz
force-pushed
the
enh/noid/notification-email-chooser
branch
from
d4afea5 to
46abeaa
Compare
This comment has been minimized.
This comment has been minimized.
blizzz
added
3. to review
|
ready for review |
blizzz
force-pushed
the
enh/noid/notification-email-chooser
branch
from
bf7d776 to
d85152e
Compare
This comment has been minimized.
This comment has been minimized.
blizzz
force-pushed
the
enh/noid/notification-email-chooser
branch
from
1032453 to
21af4b6
Compare
|
/compile /apps/settings |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- also the only way to reset when system mail cannot be modified Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
approved these changes
Sep 15, 2021
PVince81
approved these changes
Sep 15, 2021
| }) | ||
| } catch (e) { | ||
| this.handleResponse({ | ||
| errorMessage: 'Unable to choose this email for notifications', |
There was a problem hiding this comment.
Imo yes, but the existing messages were not translated either, so i kept consistency. Would leave it as follow up.
|
/backport to stable22 |
|
The backport to stable22 failed. Please do this backport manually. |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #27465
Default:
After setting different mail:
Unset option:
Unconfirmed mails cannot be used: