[stable22] add a prefix index to filecache.path, attempt 2 #29324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
blizzz,
icewind1991,
nickvergessen,
PVince81 and
skjnldsv
|
are conflicts resolved? |
Apparently not |
icewind1991
force-pushed
the
backport/28541/stable22
branch
from
7d637f2
to
a17bebd
Compare
|
resolved |
PVince81
requested changes
Oct 22, 2021
| * @throws Exception | ||
| * @since 23.0.0 | ||
| */ | ||
| public function getDatabasePlatform(); |
There was a problem hiding this comment.
introducing a new API in a backport ?
There was a problem hiding this comment.
I've updated the @since to be correct for the backport but I don't know a clean way around it
There was a problem hiding this comment.
Note that we have done backported public api's in the past like this.
I don't see a way around adding this and no real downside
|
moved to 22.2.2 |
The reason that `filecache.path` hasn't had an index added is the mysql limitation of ~1kb for indexeded fields, which is to small for the `path`, however mysql supports indexing only the first N bytes of a column instead of the entire column, allowing us to add an index even if the column is to long. Because the index doesn't cover the entire column it can't be used in all situations where a normal index would be used, but it does cover the `path like 'folder/path/%'` queries that are used in various places. Sqlite and Postgresql don't support prefix indexes, but they also don't have the 1kb limit and DBAL handles the differences in index creation. Signed-off-by: Robin Appelman <robin@icewind.nl>
having the index work properly for the queries we need it for requires some additional options which dbal does not support at the momement. to prevent making it harder to add the correct index later on we don't create the index for now on postgresql Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
MichaIng
force-pushed
the
backport/28541/stable22
branch
from
493912a
to
0aa5229
Compare
skjnldsv
approved these changes
Dec 9, 2021
solracsf
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #28541