obey accounts_data column length when inserting and searching #29926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
bug
3. to review
blizzz
requested review from
nickvergessen,
PVince81,
skjnldsv,
Pytal and
a team
|
/backport to stable23 |
PVince81
reviewed
Nov 26, 2021
| public static function shortenMultibyteString(string $subject, int $dataLength, int $accuracy = 5): string { | ||
| $temp = mb_substr($subject, 0, $dataLength); | ||
| // json encodes encapsulates the string in double quotes, they need to be substracted | ||
| while ((strlen(json_encode($temp)) - 2) > $dataLength) { |
There was a problem hiding this comment.
are there scenarios where the while loop never ends ? maybe check if $oldTemp != $temp ?
There was a problem hiding this comment.
Yes, when you provide $accuracy with <= $dataLength * -1
nickvergessen
approved these changes
Nov 26, 2021
|
Can you leave a comment in notifications to move to the utility function? |
skjnldsv
approved these changes
Nov 26, 2021
skjnldsv
added
4. to release
|
Failure unrelated |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caught with the following scenario:
Solution: since this table is only used for searching phone numbers and additional email currently, it is save to cut off the value that is being written there. To ensure searches work, we prepare the values accordingly. The shortener is taken and adjusted from https://github.com/nextcloud/notifications/blob/67aae02222755d0c7672c634bdfce3859be117b1/lib/Push.php#L485-L491.