Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing moderator overview on reshares #30884

Closed
wants to merge 3 commits into from
Closed

fixing moderator overview on reshares #30884

wants to merge 3 commits into from

Conversation

ArtificialOwl
Copy link
Member

  • fix a call to a deprecated method is returns a non managed exception
  • it now uses CircleManager. Still needs to check its availability as there is no integration of circles within core. left a TODO note.
  • This is the most efficient way to know if a user is a (inherited) member of a circle and his access level

@ArtificialOwl ArtificialOwl marked this pull request as ready for review January 28, 2022 11:46
@ArtificialOwl ArtificialOwl requested review from a team, nickvergessen, skjnldsv, CarlSchwan and come-nc and removed request for a team, juliusknorr, nickvergessen and skjnldsv January 28, 2022 11:46
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Jan 28, 2022 •
edited
Loading

(sorry for the mess, experiencing edge network, and UI had glitches :])

@ArtificialOwl ArtificialOwl requested review from a team and PVince81 and removed request for a team January 28, 2022 11:48
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/call-to-deprecated-circles-api branch 2 times, most recently from 16081c3 to 7b48969 Compare January 28, 2022 12:44
@skjnldsv skjnldsv added 2. developing Work in progress bug labels Jan 28, 2022
@skjnldsv
Copy link
Member

Psalm is not happy :)

@CarlSchwan
Copy link
Member

Psalm is not happy :)

To fix it, run:

composer install
composer psalm:update-baseline

From that I could see, it's just that we have less warning now :)

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/call-to-deprecated-circles-api branch 2 times, most recently from 0ecd1f8 to fa562f7 Compare February 3, 2022 11:31
@ArtificialOwl
Copy link
Member Author

@CarlSchwan @skjnldsv new errors does not seems related !

@ArtificialOwl
Copy link
Member Author

@CarlSchwan @PVince81 @come-nc can I have some review on this one pleas ? the drone issue does not seems related to current code

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/call-to-deprecated-circles-api branch from e6ac03b to 8c84f51 Compare February 15, 2022 08:34
come-nc
come-nc approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot vouch for the logic as I do not understand what this does exactly but code looks good now.

apps/files_sharing/lib/Controller/ShareAPIController.php Show resolved Hide resolved
PVince81
PVince81 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ArtificialOwl
Copy link
Member Author

/backport to stable23

@ArtificialOwl
Copy link
Member Author

/backport to stable22

@PVince81
Copy link
Member

please check the tests:

1) OCA\Files_Sharing\Tests\Controller\ShareAPIControllerTest::testDeleteShareShareNotFound
TypeError: Argument 8 passed to OCA\Files_Sharing\Controller\ShareAPIController::__construct() must implement interface Psr\Log\LoggerInterface, string given, called in /home/runner/work/server/server/apps/files_sharing/tests/Controller/ShareAPIControllerTest.php on line 164

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/call-to-deprecated-circles-api branch 2 times, most recently from 791ddf8 to 76281fc Compare February 18, 2022 12:09
@ArtificialOwl
Copy link
Member Author

/rebase

@ArtificialOwl
fixing moderator overview on reshares
2fc8b3c 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
fix mockup
2a29868 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
fix
460081b 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@nextcloud-command nextcloud-command force-pushed the fix/noid/call-to-deprecated-circles-api branch from 1a22165 to 460081b Compare April 1, 2022 11:30
@szaimen szaimen added this to the Nextcloud 24 milestone Apr 3, 2022
This was referenced Apr 7, 2022
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@PVince81
Copy link
Member

@ArtificialOwl please resolve the conflict.

I'm guessing this is still relevant (also for backport) despite being from January ?

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv deleted the fix/noid/call-to-deprecated-circles-api branch March 14, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
2. developing Work in progress bug
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
7 participants
@ArtificialOwl @skjnldsv @CarlSchwan @PVince81 @come-nc @blizzz @szaimen