Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable22] Fix preview generation for office documents #30971

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Feb 2, 2022

new \imagick() returns an object, but we need the image blob (binary
string) from this object.

This is a partial backport of #26531, which brings a lot of refactoring
but also contains the fix.

Fixes: #29956

Signed-off-by: Jonas Meurer jonas@freesources.org

`new \imagick()` returns an object, but we need the image blob (binary
string) from this object.

This is a partial backport of #26531, which brings a lot of refactoring
but also contains the fix.

Fixes: #29956

Signed-off-by: Jonas Meurer <jonas@freesources.org>
@mejo- mejo- added the 3. to review Waiting for reviews label Feb 2, 2022
@mejo- mejo- added this to the Nextcloud 22.2.5 milestone Feb 2, 2022
@mejo-
Copy link
Member Author

mejo- commented Feb 2, 2022

The drone CI failures are unrelated. Samba always fails on stable22, integration-transfer-ownership-features seems like a timeout.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me if it works :D

@CarlSchwan CarlSchwan merged commit 464f996 into stable22 Feb 2, 2022
@CarlSchwan CarlSchwan deleted the backport/stable22/office_preview branch February 2, 2022 14:30
@nickvergessen nickvergessen changed the title Fix preview generation for office documents [stable22] Fix preview generation for office documents Feb 2, 2022
@blizzz blizzz mentioned this pull request Feb 11, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants