Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide download button for images #31169

Merged
merged 1 commit into from
Feb 18, 2022
Merged

hide download button for images #31169

merged 1 commit into from
Feb 18, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 14, 2022 •
edited
Loading

Steps to reproduce the bug:

  1. Share an image via link and select the option to hide the download button
  2. visit the link

Before this change:

  1. The download button ist shown

After this change:

  1. The download button is hidden

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=enh/noid/hide-download-button-for-images \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 24 milestone Feb 14, 2022
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 14, 2022
@szaimen szaimen requested review from artonge, nickvergessen, a team, PVince81 and Pytal and removed request for nickvergessen and a team February 14, 2022 13:13
@szaimen szaimen marked this pull request as ready for review February 14, 2022 13:13
@szaimen
Copy link
Contributor Author

szaimen commented Feb 14, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Feb 14, 2022

/backport to stable22

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 15, 2022
@szaimen
hide download button for images
aa1c7eb 
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/hide-download-button-for-images branch from c2c0d92 to aa1c7eb Compare February 16, 2022 12:38
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 16, 2022
@szaimen

This comment was marked as resolved.

Sign in to view
@nickvergessen

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@nickvergessen nickvergessen removed their request for review February 18, 2022 09:33
@szaimen
Copy link
Contributor Author

szaimen commented Feb 18, 2022

failing test is unrelated

@szaimen szaimen merged commit ac00734 into master Feb 18, 2022
@szaimen szaimen deleted the enh/noid/hide-download-button-for-images branch February 18, 2022 10:58
This was referenced Feb 18, 2022
Merged
Merged
@szaimen szaimen mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: sharing
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
5 participants
@szaimen @nickvergessen @artonge @CarlSchwan @Pytal