Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load scripts of theming app before the dashboard #31238

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Feb 17, 2022

This allows dashboard to access OCA.Theming

This allows dashboard to access OCA.Theming

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge added this to the Nextcloud 24 milestone Feb 17, 2022
@artonge artonge requested a review from a team February 17, 2022 10:58
@artonge artonge self-assigned this Feb 17, 2022
@artonge artonge requested review from PVince81, skjnldsv and vanpertsch and removed request for a team February 17, 2022 10:58
@artonge
Copy link
Contributor Author

artonge commented Feb 17, 2022

CI failure unrelated

@artonge artonge merged commit 098dfe1 into master Feb 17, 2022
@artonge artonge deleted the fix/dashboard_theming branch February 17, 2022 12:19
@solracsf
Copy link
Member

Backport?

@artonge
Copy link
Contributor Author

artonge commented Feb 18, 2022

I don't think that it is necessary, probably introduce by #30020.

If previous versions are affected feel free to backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants