[stable22] Don't redirect when loading files index page #31256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Currently we are redirecting from ?dir=/&fileid=2 to ?dir=/. This is an issue because we then need to load two pages with full file system setup and authentification instead of one and the assets won't start loading until the second page is delivered to the user. Additionally when loading ?dir=/, we then change the url back to ?dir=/&fileid=2 (without reload) so that the next time we load the page again we do the same thing again. Depending on the speed of the server and internet connection we can save 100ms to 400ms, improving the user experience. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud
bot
requested review from
artonge,
CarlSchwan,
come-nc and
PVince81
MichaIng
requested changes
Feb 20, 2022
There was a problem hiding this comment.
Blocking as of: #31143 (comment)
Same Drone error can be seen here.
|
need to cherry pick #31294 |
Otherwise dir it's just ignored and fileid is used Signed-off-by: Carl Schwan <carl@carlschwan.eu>
MichaIng
approved these changes
Feb 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #31143