Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility with more visible focus indication for non vue apps #31584

Merged
merged 1 commit into from
May 16, 2022
Merged

Improve accessibility with more visible focus indication for non vue apps #31584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/dashboard/src/DashboardApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,9 @@ export default {

& > .panel--content {
margin: 0 16px 16px 16px;
height: 420px;
height: 424px;
// We specifically do not want scrollbars inside widgets
overflow: hidden;
overflow: visible;
}

// No need to extend height of widgets if only one column is shown
Expand Down Expand Up @@ -566,7 +566,7 @@ export default {
background-color: var(--color-background-hover)!important;
}
&:focus-visible {
border: 2px solid var(--color-main-text)!important;
box-shadow: 0 0 0 2px var(--color-main-text) !important;
}
}

Expand Down
16 changes: 13 additions & 3 deletions apps/files/css/files.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/files/css/files.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 15 additions & 1 deletion apps/files/css/files.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,9 @@ table th .columntitle {
box-sizing: border-box;
-moz-box-sizing: border-box;
vertical-align: middle;
&:focus-visible {
border-radius: 2px;
}
}
table.multiselect th .columntitle {
display: inline-block;
Expand Down Expand Up @@ -507,6 +510,9 @@ table td.selection {
&:focus + label {
background-color: var(--color-background-hover);
border-radius: var(--border-radius-pill);
outline: none !important;
border: 2px solid var(--color-primary) !important;
padding: 14px;
}
}

Expand Down Expand Up @@ -845,6 +851,10 @@ table.dragshadow td.size {
position: relative;
}

.breadcrumb .icon-home {
border-radius: var(--border-radius);
}

.breadcrumb .canDrop > a,
#filestable tbody tr.canDrop {
background-color: rgba( variables.$color-primary, .3 );
Expand Down Expand Up @@ -885,7 +895,6 @@ table.dragshadow td.size {

> a[href='#'] {
// if no link is set, no mouse feedback
box-shadow: none !important;
&, * {
cursor: default !important;
}
Expand Down Expand Up @@ -1196,6 +1205,11 @@ table.dragshadow td.size {
#showgridview:focus + & {
opacity: 1;
}

&:focus-visible,
#showgridview:focus-visible + & {
box-shadow: inset 0 0 0 2px var(--color-primary) !important;
}
}

/**
Expand Down
16 changes: 13 additions & 3 deletions apps/files/css/merged.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading