Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap oauth2 migrations inside conditions #31737

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Wrap oauth2 migrations inside conditions #31737

merged 1 commit into from
Mar 31, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Mar 28, 2022 •
edited
Loading

The migration is run during usual upgrades, so we need to wrap every step insides conditions to make sure we do not break anything.

Currently, it leads to the following error: "The column 'hashed_code' on table 'oc_oauth2_access_tokens' already exists"

Is this the correct way?

Introduced by #30276

@artonge artonge added the 3. to review Waiting for reviews label Mar 28, 2022
@artonge artonge added this to the Nextcloud 24 milestone Mar 28, 2022
@artonge artonge self-assigned this Mar 28, 2022
@artonge
Copy link
Contributor Author

artonge commented Mar 28, 2022

/backport to stable23

@artonge artonge requested review from a team, nickvergessen, juliusknorr and skjnldsv and removed request for a team March 28, 2022 16:45
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
blizzz
blizzz approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, otherwise looks good and works

lib/private/Repair/Owncloud/MigrateOauthTables.php Outdated Show resolved Hide resolved
@artonge
Wrap oauth2 migrations inside conditions
b0b8805 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 31, 2022
@nickvergessen nickvergessen merged commit eea05b0 into master Mar 31, 2022
@nickvergessen nickvergessen deleted the fix/oc_oauth2_migration branch March 31, 2022 11:43
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @nickvergessen @blizzz