Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure schema change before checking OracleConstraints #31872

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Ensure schema change before checking OracleConstraints #31872

merged 4 commits into from
Apr 7, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 7, 2022

  • Fix the oracle constraints check
  • Fix ldap migration parametters
  • Improve error logging 
    $ php80 occ upgrade
Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Setting log level to debug
Updating database schema
Updated database
Updating <user_ldap> ...
Exception: Database error when running migration 1142Date20220410143802 for app user_ldap
Column "oc_ldap_group_mapping"."ldap_dn" is type String, but exceeding the 4.000 length limit.
Update failed
Maintenance mode is kept active
Resetting log level

skjnldsv added 2 commits April 7, 2022 11:18
@skjnldsv
Ensure schema change before checking OracleConstraints
e20d5fa 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Fix createNamedParameter in LDAP migrations
1e5a879 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels Apr 7, 2022
@skjnldsv skjnldsv self-assigned this Apr 7, 2022
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Apr 7, 2022
@skjnldsv skjnldsv added the high label Apr 7, 2022
@skjnldsv
Improve error logging on migration failure
0257315 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/oracle-contrainst branch from 31cd2ac to 0257315 Compare April 7, 2022 09:49
@skjnldsv skjnldsv mentioned this pull request Apr 7, 2022
Merged
blizzz
blizzz approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + unblocks an upgrade issue of the targeted scenario

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 7, 2022
nickvergessen
nickvergessen approved these changes Apr 7, 2022
View reviewed changes
lib/private/DB/MigrationService.php Outdated Show resolved Hide resolved
lib/private/DB/MigrationService.php Outdated Show resolved Hide resolved
lib/private/DB/MigrationService.php Outdated Show resolved Hide resolved
lib/private/DB/MigrationService.php Outdated Show resolved Hide resolved
@nickvergessen
Fix typos and empty tabs
82c33be 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@blizzz blizzz merged commit 8b53b6d into master Apr 7, 2022
@blizzz blizzz deleted the fix/oracle-contrainst branch April 7, 2022 12:53
This was referenced Apr 7, 2022
Merged
Merged
@nickvergessen nickvergessen mentioned this pull request Apr 8, 2022
Closed
8 tasks
@icewind1991 icewind1991 mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@blizzz blizzz blizzz approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug high
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @nickvergessen @blizzz @come-nc