Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for ZIP getAllFilesStat() #31944

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Member

Surprise! Bonus unit tests! 🪙

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added the 3. to review Waiting for reviews label Apr 12, 2022
@PVince81 PVince81 self-assigned this Apr 12, 2022
@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 12, 2022
blizzz
blizzz previously requested changes Apr 12, 2022
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

milestone not set

@PVince81 PVince81 added this to the Nextcloud 24 milestone Apr 12, 2022
@PVince81 PVince81 dismissed blizzz’s stale review April 12, 2022 14:00

milestone added

@PVince81
Copy link
Member Author

damn "Failed asserting that 1329531894 matches expected 1329528294"

I didn't expect the timestamps in the test file to change. I'll have a look later...

@blizzz blizzz added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Apr 13, 2022
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blizzz blizzz mentioned this pull request Apr 13, 2022
@PVince81
Copy link
Member Author

will finish this another time, don't wait for it

@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@PVince81
Copy link
Member Author

abandoned, I don't have time for this minor detail

@PVince81 PVince81 closed this Dec 16, 2022
@skjnldsv skjnldsv deleted the enh/noid/zip-expose-stat-tests branch March 14, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants