Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction around mass mounts operations #32038

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Add transaction around mass mounts operations #32038

merged 1 commit into from
Mar 8, 2023

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Apr 21, 2022
@nickvergessen nickvergessen requested review from a team and vanpertsch and removed request for a team April 25, 2022 06:58
@nickvergessen nickvergessen requested review from a team and blizzz and removed request for vanpertsch and a team June 3, 2022 12:17
@PVince81
Copy link
Member

@icewind1991 please review and evaluate if still relevant for the new style FS code in 24

@blizzz
Copy link
Member

blizzz commented Jul 7, 2022

/rebase

@nickvergessen nickvergessen force-pushed the bugfix/noid/only-update-indexes-after-changing-all-mounts branch from 448f17b to e4e8033 Compare July 8, 2022 08:56
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Possible performance regression detected

Show Output 
13 queries added

≠ /remote.php/dav/files/test with 5 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
  + "START TRANSACTION"
  + "COMMIT"
  + "START TRANSACTION"
  + "COMMIT"
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
  + "START TRANSACTION"
  + "COMMIT"
≠ /remote.php/dav/files/test/many_files with 4 queries added
  + "START TRANSACTION"
  + "COMMIT"
  + "START TRANSACTION"
  + "COMMIT"
≠ /remote.php/dav/files/test/new_file.txt with 2 queries added
  + "START TRANSACTION"
  + "COMMIT"
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
  + "START TRANSACTION"
  + "COMMIT"

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@nickvergessen
Copy link
Member Author

/rebase

@nickvergessen
Add transaction around mass mounts operations
6b0cef6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nextcloud-command nextcloud-command force-pushed the bugfix/noid/only-update-indexes-after-changing-all-mounts branch from e4e8033 to 6b0cef6 Compare March 7, 2023 19:59
@nickvergessen nickvergessen merged commit 11a0cb7 into master Mar 8, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/only-update-indexes-after-changing-all-mounts branch March 8, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@blizzz blizzz blizzz approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: filesystem
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @PVince81 @blizzz @CarlSchwan