Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Don't use hash to check if binding worked #32282

Merged
merged 1 commit into from
May 9, 2022
Merged

[stable24] Don't use hash to check if binding worked #32282

merged 1 commit into from
May 9, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #32246

@CarlSchwan @backportbot-nextcloud
Don't use slow hashing to check the LDAP binding
a9e674b 
Using password_hash is expensive and should be used for hashing
passwords when saving them in the database. Here we just want to see if
the bind was already done with the given password, so use a fast hashing
algorythm.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.1 milestone May 5, 2022
CarlSchwan
CarlSchwan approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci failure unrelated

@come-nc come-nc merged commit f2810d0 into stable24 May 9, 2022
@come-nc come-nc deleted the backport/32246/stable24 branch May 9, 2022 07:30
@blizzz blizzz mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
performance 🚀
Projects
None yet
Milestone
Nextcloud 24.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlSchwan @come-nc