Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent all interraction with content preview if hideDownload is enabled #32343

Closed
wants to merge 1 commit into from
Closed

Prevent all interraction with content preview if hideDownload is enabled #32343

wants to merge 1 commit into from

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 12, 2022 •
edited
Loading

  • Prevent printing content
  • Prevent mouse interaction, drag/drop, moving content into a new tab... etc
  • PDF already prevent selecting/printing/downloading if enabled

@skjnldsv
Prevent all interraction with content preview if hideDownload is enabled
d00ede0 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone May 12, 2022
@skjnldsv skjnldsv requested a review from a team May 12, 2022 07:17
@skjnldsv skjnldsv self-assigned this May 12, 2022
@skjnldsv skjnldsv requested review from PVince81, Pytal, szaimen and artonge and removed request for a team May 12, 2022 07:17
@skjnldsv skjnldsv mentioned this pull request May 12, 2022
Closed
5 tasks
szaimen
szaimen requested changes May 13, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to break the filelist on public shares when hidedownload is enabled:
I can no longer open any file with the viewer:
image

This was referenced Aug 12, 2022
Merged
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 25, Nextcloud 26 Aug 18, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 26, Nextcloud 27 Feb 23, 2023
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 3, 2023
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 2, 2023
@skjnldsv skjnldsv removed this from the Nextcloud 28 milestone Sep 2, 2023
@skjnldsv skjnldsv closed this Feb 7, 2024
@skjnldsv skjnldsv deleted the feat/hide-download-public-share branch February 7, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen requested changes

@PVince81 PVince81 Awaiting requested review from PVince81

@Pytal Pytal Awaiting requested review from Pytal

@artonge artonge Awaiting requested review from artonge

Assignees

@skjnldsv skjnldsv

Labels
2. developing Work in progress enhancement security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @szaimen