Fix status handling #32618
Merged
Fix status handling #32618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
May 27, 2022
nickvergessen
commented
| Problem | Before | After |
|---|---|---|
| Predefined status missing in the settings drop down |  |
 |
| Invalid date shown in modal when opened inside talk |  |
 |
When a predefined status message was used, the status was not "processed" so it was missing the translated message and the icon in the dropdown and the menu afterwards Signed-off-by: Joas Schilling <coding@schilljs.com>
…pdates This e.g. happens from the talk participant list which only has the status, message and icon. Due to the overwriting e.g. the clearAt was overwritten with null and afterwards the status modal showed "Invalid date" as "Clear at" Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
CarlSchwan,
a team,
artonge,
skjnldsv and
vanpertsch
and removed request for
a team
|
/backport to stable24 |
|
/backport to stable23 |
skjnldsv
approved these changes
May 27, 2022
|
/backport to stable22 |
CarlSchwan
approved these changes
May 27, 2022
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
This was referenced May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.