Don't spam the log with fatals when maintenance mode is enabled or an… #32800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… upgrade has to be done Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
commented
Jun 9, 2022
| if (isset($this->nonFatalExceptions[$exceptionClass]) || | ||
| ( | ||
| $exceptionClass === ServiceUnavailable::class && | ||
| $ex->getMessage() === 'System in maintenance mode.' |
There was a problem hiding this comment.
This string did not match the english source string.
But even then it was translated so for non-english people it would still have logged fatal
nickvergessen
added
bug
3. to review
|
/backport to stable24 |
|
/backport to stable23 |
|
/backport to stable22 |
blizzz
approved these changes
Jun 9, 2022
|
The backport to stable24 failed. Please do this backport manually. |
|
/backport to stable24 |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
|
/backport to stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… upgrade has to be done
Signed-off-by: Joas Schilling coding@schilljs.com