Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing space(s) from var_export #32839

Closed
wants to merge 1 commit into from
Closed

Conversation

xerc
Copy link

@xerc xerc commented Jun 12, 2022

https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_core_whitespace

-  'enabledPreviewProviders' => 
+  'enabledPreviewProviders' =>

@kesselb
Copy link
Contributor

kesselb commented Jun 12, 2022

Thanks @xerc for sending a pull request 👍

Would you mind to add some words what this patch does and why?

@@ -257,7 +257,7 @@
// Create a php file ...
$content = "<?php\n";
$content .= '$CONFIG = ';
$content .= var_export($this->cache, true);
$content .= preg_replace('/\s+$/m', '', var_export($this->cache, true));

Check failure

Code scanning / Psalm

TaintedHtml

Detected tainted HTML
@@ -257,7 +257,7 @@
// Create a php file ...
$content = "<?php\n";
$content .= '$CONFIG = ';
$content .= var_export($this->cache, true);
$content .= preg_replace('/\s+$/m', '', var_export($this->cache, true));

Check failure

Code scanning / Psalm

TaintedHtml

Detected tainted HTML
@xerc
Copy link
Author

xerc commented Jun 12, 2022

"remove trailing space(s) from var_export" to NOT show error-mark caused within git default turned on blank-at-eol

Bildschirmfoto 2022-06-13 um 01 30 27

@szaimen szaimen added the 3. to review Waiting for reviews label Apr 13, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 13, 2023
This was referenced May 3, 2023
Copy link
Author

@xerc xerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaintedHtml false-positives

@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv
Copy link
Member

As there is no feedback since a while I will close this ticket. If this is still happening please make sure to upgrade to the latest version. After that, feel free to reopen.

@skjnldsv skjnldsv closed this Feb 24, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 24, 2024
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews and removed 3. to review Waiting for reviews labels Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants