Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icewind/streams to 0.5.2 #3293

Merged
merged 1 commit into from
Mar 1, 2017
Merged

update icewind/streams to 0.5.2 #3293

merged 1 commit into from
Mar 1, 2017

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 27, 2017

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 27, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Jan 27, 2017
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke and @Xenopathic to be potential reviewers.

@MorrisJobke
Copy link
Member

@icewind1991 sign-off missing

@MorrisJobke
Copy link
Member

@icewind1991 sign-off missing

Ping

@icewind1991
Copy link
Member Author

done

@MorrisJobke
Copy link
Member

Let's wait for this after the current RC ;)

@icewind1991
Copy link
Member Author

rebased and updated 3rdparty ref

@codecov-io
Copy link

Codecov Report

Merging #3293 into stable11 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable11    #3293      +/-   ##
==============================================
+ Coverage        57.5%   57.51%   +<.01%     
  Complexity      19484    19484              
==============================================
  Files            1211     1211              
  Lines           72648    72648              
  Branches         1235     1235              
==============================================
+ Hits            41779    41782       +3     
+ Misses          30869    30866       -3
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 92.72% <0%> (+0.16%) 119% <0%> (ø)
lib/private/Files/Storage/DAV.php 7.32% <0%> (+0.23%) 159% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e88c6...c677ede. Read the comment docs.

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me 👍

Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
Copy link
Member

I updated the 3rdparty module

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I mounted some external storages and it still works

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 28, 2017
@icewind1991 icewind1991 merged commit 1a5f849 into stable11 Mar 1, 2017
@icewind1991 icewind1991 deleted the streams52-11 branch March 1, 2017 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants