Rename setting name to reduce its length #32998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable24 |
|
/backport to stable23 |
CarlSchwan
approved these changes
Jun 23, 2022
ArtificialOwl
approved these changes
Jun 23, 2022
CarlSchwan
added
4. to release
|
/drone/src/tests/lib/Collaboration/Collaborators/UserPluginTest.php:825 are failing |
artonge
force-pushed
the
fix/setting_name
branch
from
d048f10
to
7e29001
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
fix/setting_name
branch
from
7e29001
to
347ca20
Compare
|
I forgot some rename here and there, all green now. I also removed some legacy frontend note that are linked to the setting but not needed anymore. |
|
The backport to stable23 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #31932
DB is limiting setting name to 64, but this was 72.