Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Talk federation authentication #33105

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Talk federation authentication #33105

merged 1 commit into from
Oct 9, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 4, 2022 •
edited
Loading

@nickvergessen nickvergessen added the 2. developing Work in progress label Jul 4, 2022
@nickvergessen nickvergessen self-assigned this Jul 4, 2022
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Jul 4, 2022
@nickvergessen nickvergessen mentioned this pull request Jul 4, 2022
Merged
1 task
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@nickvergessen nickvergessen force-pushed the feature/noid/talk-federation-auth branch from b04d4bf to 4ec3890 Compare March 10, 2023 14:23
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@nickvergessen nickvergessen force-pushed the feature/noid/talk-federation-auth branch from 4ec3890 to ef1298a Compare October 9, 2023 08:25
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 9, 2023
@nickvergessen nickvergessen marked this pull request as ready for review October 9, 2023 12:29
@bigcat88
Copy link
Member

bigcat88 commented Oct 9, 2023

Am I correct, this PR implements skip of the auth for the requests with X-Nextcloud-Federation header and authentication will be done by Talk?

@nickvergessen
Copy link
Member Author

Am I correct, this PR implements skip of the auth for the requests with X-Nextcloud-Federation header and authentication will be done by Talk?

Exactly, because those federated users are not a user backend.

juliusknorr
juliusknorr approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Any specific reason to not just add it as an early return within handleLogin?

@nickvergessen
Talk federation authentication
7998afe 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Any specific reason to not just add it as an early return within handleLogin?

No, sounds actually more save, let me do that.

@nickvergessen nickvergessen force-pushed the feature/noid/talk-federation-auth branch from ef1298a to 7998afe Compare October 9, 2023 13:46
@nickvergessen nickvergessen disabled auto-merge October 9, 2023 15:06
@nickvergessen nickvergessen merged commit ab15cff into master Oct 9, 2023
38 of 40 checks passed
@nickvergessen nickvergessen deleted the feature/noid/talk-federation-auth branch October 9, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews feature: authentication feature: federation
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @bigcat88 @juliusknorr @blizzz