Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sabre dav to 4.4.0 in stable24 #33352

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jul 26, 2022

Fixes encoding problems on PHP 8.1

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added this to the Nextcloud 24.0.4 milestone Jul 26, 2022
@come-nc come-nc requested a review from a team July 26, 2022 09:04
@come-nc come-nc self-assigned this Jul 26, 2022
@come-nc come-nc requested review from ArtificialOwl, icewind1991 and CarlSchwan and removed request for a team July 26, 2022 09:05
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

note: seems there are laravel updates as well ? make sure these are/were safe

@come-nc
Copy link
Contributor Author

come-nc commented Jul 26, 2022

I do not understand the current state of 3rdparty submodule on stable24, it does not match stable24 branch of 3rdparty I think, it contains laravel/serializable-closure which was only added in master to my knowledge.

@PVince81
Copy link
Member

@come-nc maybe someone submit a PR to 3rdparty/stable24 and forgot to update the pointer on stable24 ?

you might be able to trace it back

@come-nc
Copy link
Contributor Author

come-nc commented Jul 26, 2022

I think it is from #33009

Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the unrelated change are due to the fact that the stable24 3rdparty submodule is not pointing to the correct commit. This commit also fix it

@come-nc come-nc merged commit 7d069cd into stable24 Aug 1, 2022
@come-nc come-nc deleted the fix/bump-sabre-dav-to-4.4.0-in-stable24 branch August 1, 2022 09:32
@blizzz blizzz mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants