Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Bump underscore from 1.12.0 to 1.12.1 #33366

Merged

Conversation

PVince81
Copy link
Member

Like #31984 for stable23

@PVince81 PVince81 added the 3. to review Waiting for reviews label Jul 26, 2022
@PVince81 PVince81 added this to the Nextcloud 23.0.8 milestone Jul 26, 2022
@PVince81 PVince81 self-assigned this Jul 26, 2022
@PVince81
Copy link
Member Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the vincentdabot/npm_and_yarn/stable23/underscore-1.12.1 branch from 137b56c to 666d05b Compare July 26, 2022 21:32
@Pytal
Copy link
Member

Pytal commented Jul 26, 2022

/rebase

@PVince81 PVince81 force-pushed the vincentdabot/npm_and_yarn/stable23/underscore-1.12.1 branch from 666d05b to 2014a3d Compare July 27, 2022 08:43
@PVince81
Copy link
Member Author

I did add the commit that fixes the test but it's not working here, needs further investigation

PVince81 added 2 commits July 27, 2022 14:07
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the vincentdabot/npm_and_yarn/stable23/underscore-1.12.1 branch from 2014a3d to 419cb21 Compare July 27, 2022 12:08
@PVince81
Copy link
Member Author

seems my rebase/conflict-solving had annihilated the commit

I've brought it back now

@nickvergessen nickvergessen merged commit 7fe507a into stable23 Jul 27, 2022
@nickvergessen nickvergessen deleted the vincentdabot/npm_and_yarn/stable23/underscore-1.12.1 branch July 27, 2022 19:54
@blizzz blizzz mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants