Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add birthday calendar configuration to groupware personal settings UI #33397

Closed
wants to merge 10 commits into from
Closed

Add birthday calendar configuration to groupware personal settings UI #33397

wants to merge 10 commits into from

Conversation

cneukom
Copy link

@cneukom cneukom commented Jul 28, 2022

Closes #1505.

Add birthday calendar configuration to personal settings UI
19b08b3 
Signed-off-by: Cédric Neukom <github@webguy.ch>
@szaimen szaimen added enhancement 3. to review Waiting for reviews labels Jul 28, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Jul 28, 2022
@szaimen szaimen requested review from st3iny, ChristophWurst, a team, PVince81, artonge and Pytal and removed request for a team July 28, 2022 19:59
Cédric Neukom added 3 commits July 28, 2022 22:11
Fix eslint
4a0c35d 
Signed-off-by: Cédric Neukom <github@webguy.ch>
Fix eslint, attempt #2
0e4dae1 
Signed-off-by: Cédric Neukom <github@webguy.ch>
Fix import path
a87e93f 
Signed-off-by: Cédric Neukom <github@webguy.ch>
@cneukom cneukom mentioned this pull request Jul 28, 2022
Closed
@cneukom cneukom mentioned this pull request Jul 28, 2022
Open
Cédric Neukom added 3 commits July 28, 2022 23:01
Remove obsolete initialState
66fef08 
Signed-off-by: Cédric Neukom <github@webguy.ch>
Provide initial birthdayCalendarReminderOffset as initialState
13364c4 
Signed-off-by: Cédric Neukom <github@webguy.ch>
Provide initial birthdayCalendarEnabled as initialState instead of fe…
865967b 
…tching it from the DAV server

Signed-off-by: Cédric Neukom <github@webguy.ch>
@tcitworld tcitworld changed the title Add birthday calendar configuration to personal settings UI Add birthday calendar configuration to groupware personal settings UI Aug 1, 2022
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
Separate initial state for BirthdayCalendarSettings and remove manual…
ebc7958 
…ly added translations.

Signed-off-by: Cédric Neukom <github@webguy.ch>
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@tcitworld tcitworld self-requested a review August 19, 2023 09:09
@joshtrichards joshtrichards mentioned this pull request Sep 30, 2023
Open
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@Epse
Copy link

Epse commented Jan 25, 2024

This feels like necro-ing, but what are the realistic odds of this PR landing anytime soon? It has been open for a painful while now. I was looking into the issue solved by this earlier, but it seems code contributions are not needed at this time.

@tcitworld

This comment was marked as resolved.

Sign in to view
@joshtrichards joshtrichards added the feature: caldav Related to CalDAV internals label Mar 5, 2024
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
This was referenced Mar 14, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@cneukom cneukom closed this by deleting the head repository Mar 28, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb Awaiting requested review from kesselb

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: caldav Related to CalDAV internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users should be able to choose whether reminders are generated for events in the birthday calendar
10 participants
@cneukom @tcitworld @jancborchardt @Epse @kesselb @joshtrichards @blizzz @skjnldsv @szaimen @Altahrim