Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight selected file version (Nextcloud Office) #33434

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

Jerome-Herbinet
Copy link
Member

After my PR #32492 fail, I create a new PR.

Signed-off-by: Jérôme Herbinet jerome.herbinet@arawa.fr

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

@PVince81
Copy link
Member

I assume that accessibility has been taken into consideration in the former PR's review

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

/compile amend /

@PVince81 PVince81 added enhancement 4. to release Ready to be released and/or waiting for tests to finish feature: versions labels Aug 10, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Aug 10, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
@blizzz blizzz mentioned this pull request Sep 20, 2022
@Jerome-Herbinet
Copy link
Member Author

Is the fact that some checks are not successful related to my work or should I not worry?

@blizzz blizzz mentioned this pull request Sep 22, 2022
2 tasks
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

@Jerome-Herbinet do you mind rebasing and fixing the conflicts? Thanks a lot! :)

@szaimen szaimen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Apr 17, 2023
After my PR nextcloud#32492 fail, I create a new PR.

Signed-off-by: Jérôme Herbinet <jerome.herbinet@arawa.fr>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented Apr 18, 2023

CI failure unrleated

@szaimen szaimen merged commit c0dbcb2 into nextcloud:master Apr 18, 2023
@Jerome-Herbinet Jerome-Herbinet deleted the patch-2 branch August 29, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants