-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce indent for app-navigation-caption
#34082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it always looks better if the text is aligned, and in the case of these headings it gives them the necessary breathing room to highlight them more too. But what do you think @nimishavijay @marcoambrosini? |
Agreed with @jancborchardt, we always try to make sure all text is left aligned. |
I prefer left-alignment tbh. I don't agree with the "stand-out" argument you make @jancborchardt. I think it actually works the other way around: if it's left aligned, the fact that the caption "breaks" an otherwise homogenous column of text makes it stand out more. edit: just saw your comment @nimishavijay. Now I'm not sure what @jancborchardt meant 😅 |
@jancborchardt, @marcoambrosini, and @nimishavijay, Perhaps we can increase the |
Alright, @meichthys then let’s get in your improvement – however, how come it is 15px? We should work with multiples of 4px which is our baseline. So you could use e.g.: Regarding the increased font-size: That is only for headings, but not for simple captions like this. :) The focus should be on the content, the entries themselves. |
Signed-off-by: meichthys <10717998+meichthys@users.noreply.github.com>
Signed-off-by: MeIchthys <10717998+meichthys@users.noreply.github.com> Signed-off-by: meichthys <10717998+meichthys@users.noreply.github.com>
@jancborchardt we should be good to go. |
@meichthys can you please rebase, run npm ci and npm run build and commit the files here? Thanks a lot! |
Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. |
No description provided.