Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear search results when remove search query #34140

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Clear search results when remove search query #34140

merged 1 commit into from
Sep 20, 2022

Conversation

CarlSchwan
Copy link
Member

No description provided.

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Sep 19, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 19, 2022
@CarlSchwan CarlSchwan requested a review from a team September 19, 2022 14:46
@CarlSchwan CarlSchwan self-assigned this Sep 19, 2022
@CarlSchwan CarlSchwan requested review from PVince81, Pytal and szaimen and removed request for a team September 19, 2022 14:46
szaimen
szaimen requested changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt seem to fix the issue in my testing. is maybe the commited js outdated?

PVince81
PVince81 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

needs rebase and recompile :-/

@PVince81
Copy link
Member

/backport to stable24

szaimen
szaimen approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now, made a mistake in testing

@CarlSchwan CarlSchwan force-pushed the fix/carl/clean-search-result-when-resetting branch from cb8bcdb to 0ff0270 Compare September 19, 2022 16:19
@CarlSchwan
Clear search results when remove search query
f0cd60b 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the fix/carl/clean-search-result-when-resetting branch from 0ff0270 to f0cd60b Compare September 19, 2022 16:29
@CarlSchwan CarlSchwan merged commit d0668ce into master Sep 20, 2022
@CarlSchwan CarlSchwan deleted the fix/carl/clean-search-result-when-resetting branch September 20, 2022 10:16
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 20, 2022
Merged
1 task
This was referenced Sep 20, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@CarlSchwan CarlSchwan

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@CarlSchwan @PVince81 @Pytal @szaimen