Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move avatar clearing in the background #34142

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Move avatar clearing in the background #34142

merged 1 commit into from
Sep 27, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 19, 2022 •
edited
Loading

TODO

  • testing

@CarlSchwan CarlSchwan requested a review from blizzz September 19, 2022 17:04
@CarlSchwan CarlSchwan self-assigned this Sep 19, 2022
@CarlSchwan CarlSchwan force-pushed the move-background-clearing branch from 0f0eead to c64f0e5 Compare September 19, 2022 17:06
@blizzz
Copy link
Member

blizzz commented Sep 19, 2022

Could be considered to mark it as slow-running job that will only run in the maintenance window, but I think it should not run too long in most production cases either, so would be good with me.

@ArtificialOwl
Copy link
Member

still, if everyone put small jobs right after upgrade ... :]

@CarlSchwan CarlSchwan force-pushed the move-background-clearing branch from c64f0e5 to 49056ca Compare September 20, 2022 12:35
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 20, 2022
View reviewed changes
lib/private/Repair.php Fixed Show fixed Hide fixed
lib/private/Repair.php Fixed Show resolved Hide resolved
lib/private/Repair/ClearGeneratedAvatarCacheJob.php Fixed Show fixed Hide fixed
@szaimen szaimen added the 3. to review Waiting for reviews label Sep 21, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 21, 2022
@blizzz blizzz mentioned this pull request Sep 22, 2022
Merged
2 tasks
@CarlSchwan CarlSchwan force-pushed the move-background-clearing branch 2 times, most recently from 78d0019 to b9b32d4 Compare September 22, 2022 10:01
@CarlSchwan
Copy link
Member Author

Could be considered to mark it as slow-running job that will only run in the maintenance window, but I think it should not run too long in most production cases either, so would be good with me.

This is not implemented for QueuedJob only TimmedJob

@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz
Copy link
Member

blizzz commented Sep 22, 2022

/backport to stable25

@PVince81
Copy link
Member

@CarlSchwan can you test and tick the checkbox to confirm ?

@CarlSchwan
Copy link
Member Author

@CarlSchwan can you test and tick the checkbox to confirm ?

tested (by manually increasing the version) and it work, job is added and executed on the next cron run

PVince81
PVince81 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 22, 2022
@blizzz
Copy link
Member

blizzz commented Sep 22, 2022

NoDB tests are failing

@CarlSchwan CarlSchwan force-pushed the move-background-clearing branch from b9b32d4 to e21e536 Compare September 22, 2022 13:40
@nickvergessen nickvergessen mentioned this pull request Sep 22, 2022
Merged
@nickvergessen
Copy link
Member

Manual backport in #34192

@CarlSchwan CarlSchwan force-pushed the move-background-clearing branch 2 times, most recently from 550f85f to 6f0deac Compare September 23, 2022 10:39
@CarlSchwan
Copy link
Member Author

/rebase

@CarlSchwan
Move avatar clearing in the background
de23ff3 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@nickvergessen nickvergessen merged commit df9be44 into master Sep 27, 2022
@nickvergessen nickvergessen deleted the move-background-clearing branch September 27, 2022 09:13
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@nickvergessen
Copy link
Member

Backport was already done in #34192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@PVince81 PVince81 PVince81 approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
6 participants
@CarlSchwan @blizzz @ArtificialOwl @PVince81 @nickvergessen @szaimen