computerFileSize(): allow comma as decimal-point #34425
Conversation
Signed-off-by: Ruben Barkow-Kuder <rubo77@users.noreply.github.com>
|
maybe we should use this instead of replaceAll, which is not supported by oder browsers: |
szaimen
requested review from
a team,
PVince81,
artonge and
skjnldsv
and removed request for
a team
|
Replaceall should be fine IIRC https://caniuse.com/?search=replaceall |
| @@ -83,7 +83,7 @@ export default { | |||
| return null | |||
| } | |||
|
|
|||
| const s = string.toLowerCase().trim() | |||
| const s = string.toLowerCase().replaceAll(',', '.').trim() | |||
There was a problem hiding this comment.
I still need to test this but what happens if you enter multiple dots?
There was a problem hiding this comment.
Dots stay, only commas are replaced with dots
Firefox 76 is only 2 years old: may 5, 2020. I think, we should still support it |
|
Please test this with a German or French locale in your browser |
|
@szaimen could you please take over this pr then? I have no idea, where to search for |
I would like to but unfortunately I do not know where to look at either. Maybe someone of @nextcloud/server-frontend knows? |
|
As there is no feedback since a while I will close this ticket. If this is still happening please make sure to upgrade to the latest version. After that, feel free to reopen. |
This should fix the issue #18468 (Cannot set user quota with uneven values using locales that use a comma as decimal separator)
Signed-off-by: Ruben Barkow-Kuder rubo77@users.noreply.github.com