Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix external storages access" #34756

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 23, 2022

Reverts #33087 as it seems to break a CI test in master. Was not discovered before since the branch was not up-to-date.

@szaimen szaimen added this to the Nextcloud 26 milestone Oct 23, 2022
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991, CarlSchwan, PVince81 and skjnldsv and removed request for a team October 23, 2022 20:00
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the revert-33087-fix/30282/external-storages branch from adf47ba to 11108e8 Compare October 23, 2022 20:36
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if there's no quick way to fix the test

@szaimen
Copy link
Contributor Author

szaimen commented Oct 24, 2022

👍 if there's no quick way to fix the test

Maybe @icewind1991 knows? If not I would recommend to merge this

@szaimen
Copy link
Contributor Author

szaimen commented Oct 24, 2022

Can I please get a +1 in order to fix the test in master?

@szaimen szaimen merged commit 7835223 into master Oct 24, 2022
@szaimen szaimen deleted the revert-33087-fix/30282/external-storages branch October 24, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants