-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disabled federated scope #34785
Fix disabled federated scope #34785
Conversation
/backport to stable25 |
3de5bdc
to
e87b71b
Compare
/backport to stable25 |
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the Federation app is disabled the Federated
entry is disabled, but the text reads Not available as publishing user specific data to the lookup server is not allowed, contact your system administrator if you have any questions
, which is not the actual reason. Should the text be fixed or the Federated
entry be fully hidden (like in #26725)?
Independently of that federationEnabled
is still used by personal.info.php to set data-federation-enabled
. However, as it was moved from the template parameters to the initial state now it will be always set to false
. Is data-federation-enabled
still used anywhere? If it is that should be fixed, and if not it would be better to clean it :-)
e87b71b
to
53795d5
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
53795d5
to
531bb62
Compare
Text has been updated to Was decided previously by @jancborchardt to show all scopes even if disabled
Cleaned it up as it is not used anymore :) |
With all settings in Vue let's bring this #26725 into Vue-land as well