Update @nextcloud/dialogs and fix toasts styling #34868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable25 |
skjnldsv
added
2. developing
skjnldsv
changed the title
skjnldsv
added
3. to review
skjnldsv
force-pushed
the
fix/toasts-styling
branch
from
6141f96
to
2dcd716
Compare
|
Done, please review |
skjnldsv
force-pushed
the
fix/toasts-styling
branch
from
2dcd716
to
e0fc4bb
Compare
skjnldsv
commented
Nov 2, 2022
| .toastify.dialogs .toast-undo-button.toast-close::before, | ||
| .toastify.dialogs .toast-close.toast-close::before { | ||
| background-image: url("./close.svg"); | ||
| background-image: url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGhlaWdodD0iMTYiIHdpZHRoPSIxNiI+CiAgPHBhdGggZD0iTTE0IDEyLjNMMTIuMyAxNCA4IDkuNyAzLjcgMTQgMiAxMi4zIDYuMyA4IDIgMy43IDMuNyAyIDggNi4zIDEyLjMgMiAxNCAzLjcgOS43IDh6Ii8+Cjwvc3ZnPgo="); |
skjnldsv
commented
Nov 2, 2022
| .theme--dark .toastify.dialogs .toast-close.toast-close::before { | ||
| background-image: url("./close-dark.svg"); | ||
| background-image: url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGhlaWdodD0iMTYiIHdpZHRoPSIxNiI+CiAgPHBhdGggZD0iTTE0IDEyLjNMMTIuMyAxNCA4IDkuNyAzLjcgMTQgMiAxMi4zIDYuMyA4IDIgMy43IDMuNyAyIDggNi4zIDEyLjMgMiAxNCAzLjcgOS43IDh6IiBzdHlsZT0iZmlsbC1vcGFjaXR5OjE7ZmlsbDojZmZmZmZmIi8+Cjwvc3ZnPgo="); |
artonge
reviewed
Nov 2, 2022
artonge
approved these changes
Nov 2, 2022
|
ESLint is failing... |
|
skjnldsv
force-pushed
the
fix/toasts-styling
branch
from
e0fc4bb
to
cfc2ac7
Compare
skjnldsv
added
4. to release
|
AAaaaaaaand it needs a rebase... |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/toasts-styling
branch
from
cfc2ac7
to
9cc2f25
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextcloud-libraries/nextcloud-vue#3402 (comment)